#91 Refactoring Long Methods
Feb 03, 2008 | 7 minutes | Active Record, Refactoring
In this episode I walk you through an exercise in refactoring by taking a long method and making it more concise.
models/cart.rb
def shipping_price if total_weight == 0 0.00 elsif total_weight <= 3 8.00 elsif total_weight <= 5 10.00 else 12.00 end end def total_weight @total_weight ||= line_items.to_a.sum(&:weight) end
models/line_item.rb
def weight for_download? ? 0 : product.weight end
